fix: Guarantee angle periodicity after KF filtering and smoothing #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
changed the title
AJPfleger
reviewed
Oct 2, 2024
I don't think we are hitting this case very often otherwise we would have spotted it in physmon already |
|
I do not observe any performance difference for the track finding |
github-actions
bot
added
Component - Examples
AJPfleger
previously approved these changes
Oct 18, 2024
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
AJPfleger
approved these changes
Oct 18, 2024
|
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
…ts-project#3684) I noticed a few cases where the angles escape their valid range after a KF update / smoothing. We can avoid that by normalizing the angles back to their range after update. In principle other params like local position and momentum are also constrained and might need checking+fixing but for those I am not sure how to do it right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few cases where the angles escape their valid range after a KF update / smoothing. We can avoid that by normalizing the angles back to their range after update.
In principle other params like local position and momentum are also constrained and might need checking+fixing but for those I am not sure how to do it right now.