Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GeoModel changes for Gen1 ITk #3685

Merged
merged 6 commits into from
Oct 8, 2024
Merged

feat: GeoModel changes for Gen1 ITk #3685

merged 6 commits into from
Oct 8, 2024

Conversation

benjaminhuth
Copy link
Member

No description provided.

@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Oct 2, 2024
@paulgessinger paulgessinger added this to the next milestone Oct 7, 2024
@benjaminhuth benjaminhuth marked this pull request as ready for review October 7, 2024 12:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

📊: Physics performance monitoring for 2ae4141

Full contents

physmon summary

@benjaminhuth @paulgessinger
Update Examples/Detectors/TGeoDetector/src/TGeoITkModuleSplitter.cpp
eb65b03 
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 198708b into acts-project:main Oct 8, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Oct 8, 2024
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [198708b]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Oct 8, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
@benjaminhuth @Rosie-Hasan
feat: GeoModel changes for Gen1 ITk (acts-project#3685)
1359519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins
Projects
None yet
Milestone
v37.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@benjaminhuth @acts-project-service @paulgessinger