Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Use correct GM variables in cmake config #3699

Merged
merged 2 commits into from
Oct 8, 2024
Merged

build: Use correct GM variables in cmake config #3699

merged 2 commits into from
Oct 8, 2024

Conversation

paulgessinger
Copy link
Member

The generated CMake config was using the wrong version variables from GeoModel.

@paulgessinger
build: Use correct GM variables in cmake config
2173eb1 
The generated CMake config was using the wrong version variables from
GeoModel.
@paulgessinger paulgessinger added this to the next milestone Oct 7, 2024
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

📊: Physics performance monitoring for 27ed2c7

Full contents

physmon summary

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 550c0d6 into acts-project:main Oct 8, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Oct 8, 2024
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [550c0d6]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Oct 8, 2024
paulgessinger added a commit that referenced this pull request Oct 9, 2024
@paulgessinger
build: Use correct GM variables in cmake config (#3699)
4eb0007 
The generated CMake config was using the wrong version variables from GeoModel.
@paulgessinger paulgessinger mentioned this pull request Oct 9, 2024
Merged
kodiakhq bot pushed a commit that referenced this pull request Oct 9, 2024
@paulgessinger
test: Add GeoModel plugin to Downstream project test (#3704)
4c7ae2b 
This would have caught the issue fixed in #3699.
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
@paulgessinger @Rosie-Hasan
build: Use correct GM variables in cmake config (acts-project#3699)
853820c 
The generated CMake config was using the wrong version variables from GeoModel.
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
@paulgessinger @Rosie-Hasan
test: Add GeoModel plugin to Downstream project test (acts-project#3704)
1cb9787 
This would have caught the issue fixed in acts-project#3699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarloVarni CarloVarni CarloVarni approved these changes

@benjaminhuth benjaminhuth Awaiting requested review from benjaminhuth

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Milestone
v37.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @acts-project-service @CarloVarni