Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some unnecessary includes #3700

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

jmcarcell
Copy link
Contributor

Builds fine on GCC 14 and Clang 18.

@asalzburger asalzburger added this to the next milestone Oct 8, 2024
@asalzburger
Copy link
Contributor

Looks like there was one / a few too many removed.

@jmcarcell
Copy link
Contributor Author

I added the missing one, that was one file I didn't touch so it was relying on one of the included files to include IndexSourceLink.hpp.

@paulgessinger
Copy link
Member

@jmcarcell I invited you to the CI perms team. Can you accept that so the CI can run?

Copy link

github-actions bot commented Oct 9, 2024

📊: Physics performance monitoring for 85f1a31

Full contents

physmon summary

Copy link

sonarqubecloud bot commented Oct 9, 2024

@kodiakhq kodiakhq bot merged commit 464fd46 into acts-project:main Oct 9, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Oct 9, 2024
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 9, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Event Data Model Fails Athena tests This PR causes a failure in the Athena tests Seeding Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants