feat: Delayed Grid construction for Portals

[paulgessinger]

This PR does three things:

• PortalLinkBase::merge no longer does merging of grids or trivials into a combined grid. This has been observed to lead to accumulating floating point imprecision.
• CompositePortalLink gets a method to make a grid if (and only if) it is composed of a set of TrivialPortalLinks.
• Portal::fuse will attempt to convert CompositePortalLinks composed of only TrivialPortalLinks to a single GridPortalLink before fusing it with the other portal.

In combination, this avoids the floating point issues and produces correctly sized grids.

Part of #3502.

---

This pull request introduces several enhancements and bug fixes to the Core/include/Acts/Geometry module, focusing on improving the CompositePortalLink and GridPortalLink classes. The most important changes include the addition of new constructors, the introduction of the makeGrid method, and various adjustments to ensure compatibility and correctness.

Enhancements to CompositePortalLink:

• Added new constructors to allow the creation of composite portals from multiple links and to handle nested composites. (Core/include/Acts/Geometry/CompositePortalLink.hpp, [1] [2]
• Introduced the makeGrid method to convert composite portal links into grid portal links under specific conditions. (Core/include/Acts/Geometry/CompositePortalLink.hpp, Core/src/Geometry/CompositePortalLink.cppR180-R297)

Adjustments to GridPortalLink:

• Changed the type of atLocalBins methods to return const TrackingVolume* instead of TrackingVolume*. (Core/include/Acts/Geometry/GridPortalLink.hpp, [1] [2] [3] [4]
• Updated internal grid type to use const TrackingVolume*. (Core/include/Acts/Geometry/GridPortalLink.hpp, Core/include/Acts/Geometry/GridPortalLink.hppL402-R402)

Bug Fixes and Code Improvements:

• Moved mergedSurface function to an anonymous namespace in the implementation file and refactored it for better error handling and type safety. (Core/src/Geometry/CompositePortalLink.cpp, [1] [2]
• Improved the isSameSurface function to include detailed checks for surface bounds and transformations. (Core/src/Geometry/Portal.cpp, Core/src/Geometry/Portal.cppL308-R357)
• Enhanced logging and error messages for better debugging and clarity. (Core/src/Geometry/Portal.cpp, [1] [2]

These changes collectively improve the functionality, safety, and maintainability of the Acts geometry module, particularly in handling complex portal link structures.

[github-actions]

📊: Physics performance monitoring for c64751b

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ CKF | trackfinding | single muon | truth smeared seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF | trackfinding | single muon | truth estimated seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF | trackfinding | single muon | default seeding
• ✅ Track Summary CKF | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF | trackfinding | single muon | orthogonal seeding
• ✅ Track Summary CKF | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Track Summary CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Track Summary CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
58.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[acts-project-service]

🔴 Athena integration test results [9bd074c]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job	report
🟢	report_pull_request
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	test_ActsDumpGeometryIdentifiers
🟢	test_ActsCheckObjectCountsCachedWorkflow
🟢	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflowCached
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🔴	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_unit_tests