Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Integrate source link container into measurements container in Examples #3732

Merged
merged 14 commits into from
Oct 15, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Oct 14, 2024

The source link container seems not to carry any additional information compared to the measurement container. The only important difference between them is that the source link container is sorted by geometry. I integrated a sorted container into the measurement container, even though this might not be strictly necessary it plays nicer with the existing functionality of accessing such a sorted container.

@andiwand andiwand added this to the next milestone Oct 14, 2024
@andiwand
Copy link
Contributor Author

Copy link

github-actions bot commented Oct 14, 2024

📊: Physics performance monitoring for c241042

Full contents

physmon summary

@andiwand andiwand marked this pull request as ready for review October 14, 2024 17:10
paulgessinger
paulgessinger previously approved these changes Oct 14, 2024
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. In principle, the idea was to have an example of how to work with source links in the examples, but I concede that what we currently had in there wasn't a particularly good example overall.

@andiwand
Copy link
Contributor Author

Ok. In principle, the idea was to have an example of how to work with source links in the examples, but I concede that what we currently had in there wasn't a particularly good example overall.

I think the changed version is not much better in that regards but I would have to touch much more code to get there. My original goal was to remove the collections of source links as a whole but we rely a lot on the geometry multimap thingy.

Copy link

@kodiakhq kodiakhq bot merged commit dd49200 into acts-project:main Oct 15, 2024
42 checks passed
@andiwand andiwand deleted the ex-remove-sourcelink-container branch October 15, 2024 11:43
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
… in Examples (acts-project#3732)

The source link container seems not to carry any additional information compared to the measurement container. The only important difference between them is that the source link container is sorted by geometry. I integrated a sorted container into the measurement container, even though this might not be strictly necessary it plays nicer with the existing functionality of accessing such a sorted container.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants