-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Integrate source link container into measurements container in Examples #3732
refactor: Integrate source link container into measurements container in Examples #3732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. In principle, the idea was to have an example of how to work with source links in the examples, but I concede that what we currently had in there wasn't a particularly good example overall.
I think the changed version is not much better in that regards but I would have to touch much more code to get there. My original goal was to remove the collections of source links as a whole but we rely a lot on the geometry multimap thingy. |
…acts into ex-remove-sourcelink-container
Quality Gate passedIssues Measures |
… in Examples (acts-project#3732) The source link container seems not to carry any additional information compared to the measurement container. The only important difference between them is that the source link container is sorted by geometry. I integrated a sorted container into the measurement container, even though this might not be strictly necessary it plays nicer with the existing functionality of accessing such a sorted container.
The source link container seems not to carry any additional information compared to the measurement container. The only important difference between them is that the source link container is sorted by geometry. I integrated a sorted container into the measurement container, even though this might not be strictly necessary it plays nicer with the existing functionality of accessing such a sorted container.