-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DetrayMaterialConversion for Gen2 #3748
Merged
kodiakhq
merged 9 commits into
acts-project:main
from
asalzburger:fix-detray-material-conversion
Oct 18, 2024
Merged
fix: DetrayMaterialConversion for Gen2 #3748
kodiakhq
merged 9 commits into
acts-project:main
from
asalzburger:fix-detray-material-conversion
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
reviewed
Oct 17, 2024
Plugins/Detray/include/Acts/Plugins/Detray/DetrayConversionUtils.hpp
Outdated
Show resolved
Hide resolved
…ls.hpp Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
niermann999
approved these changes
Oct 18, 2024
Quality Gate passedIssues Measures |
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
The Detray material conversion was broken due to missing locality of the index map. It renames the cache object to simply `Cache` since it does more now, and through the namespace it gets clear that it is the conversion cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Detray material conversion was broken due to missing locality of the index map.
It renames the cache object to simply
Cache
since it does more now, and through the namespace it gets clear that it is the conversion cache.