Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DetrayMaterialConversion for Gen2 #3748

Merged

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Oct 17, 2024

The Detray material conversion was broken due to missing locality of the index map.

It renames the cache object to simply Cache since it does more now, and through the namespace it gets clear that it is the conversion cache.

@asalzburger asalzburger added this to the next milestone Oct 17, 2024
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

📊: Physics performance monitoring for 735f381

Full contents

physmon summary

asalzburger and others added 4 commits October 17, 2024 22:05
…ls.hpp

Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com>
Copy link

@kodiakhq kodiakhq bot merged commit 3ea63a0 into acts-project:main Oct 18, 2024
42 checks passed
@paulgessinger paulgessinger modified the milestones: next, v37.2.0 Oct 24, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
The Detray material conversion was broken due to missing locality of the index map.

It renames the cache object to simply `Cache` since it does more now, and through the namespace it gets clear that it is the conversion cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants