Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move default constructor impl in CPP file #3752

Merged
merged 2 commits into from
Oct 18, 2024
Merged

fix: Move default constructor impl in CPP file #3752

merged 2 commits into from
Oct 18, 2024

Conversation

paulgessinger
Copy link
Member

This (somehow) fixes a faulty -Wnull-dereference case in GCC 11

@paulgessinger
fix: Move default constructor impl in CPP file
9201080 
This (somehow) fixes a faulty `-Wnull-dereference` case in GCC 11
@paulgessinger paulgessinger added this to the next milestone Oct 17, 2024
andiwand
andiwand approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc11 🙄

@github-actions github-actions bot added the Component - Core Affects the Core module label Oct 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

📊: Physics performance monitoring for b0a404f

Full contents

physmon summary

@paulgessinger paulgessinger mentioned this pull request Oct 18, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 1d1ccbd into acts-project:main Oct 18, 2024
42 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Oct 18, 2024 •
edited
Loading

✅ Athena integration test results

✅ All tests successful

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 run_workflow_tests_run4_mc
🟡 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsCachedWorkflow
🟢 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_unit_tests

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Oct 18, 2024
kodiakhq bot pushed a commit that referenced this pull request Oct 22, 2024
@paulgessinger
ci: Download dependencies as tarball (#3520)
d738c82 
Blocked by:

- #3753 
- #3752
- #3751
@paulgessinger paulgessinger modified the milestones: next, v37.2.0 Oct 24, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
@paulgessinger @Rosie-Hasan
fix: Move default constructor impl in CPP file (acts-project#3752)
71a42a1 
This (somehow) fixes a faulty `-Wnull-dereference` case in GCC 11
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
@paulgessinger @Rosie-Hasan
ci: Download dependencies as tarball (acts-project#3520)
6b1c551 
Blocked by:

- acts-project#3753 
- acts-project#3752
- acts-project#3751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module
Projects
None yet
Milestone
v37.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @acts-project-service @andiwand