-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add standalone digitization coordinates converter #3765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a simple unit test either in C++ or even better in pytest to just run this code? That's just to make sure it doesn't spontaneously break.
Of course, which test file would fit it the best? |
I added the test to It seems that linux_ubuntu_2204_clang failure is unrelated but let me know if this is not the case. Otherwise the MR seems to be ready. |
Quality Gate passedIssues Measures |
…#3765) This adds simple python bindings to the test framework to convert between global and local coordinates.
…#3765) This adds simple python bindings to the test framework to convert between global and local coordinates.
This adds simple python bindings to the test framework to convert between global and local coordinates.