Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add standalone digitization coordinates converter #3765

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

ntadej
Copy link
Contributor

@ntadej ntadej commented Oct 21, 2024

This adds simple python bindings to the test framework to convert between global and local coordinates.

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

📊: Physics performance monitoring for ed3ddd3

Full contents

physmon summary

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a simple unit test either in C++ or even better in pytest to just run this code? That's just to make sure it doesn't spontaneously break.

@ntadej
Copy link
Contributor Author

ntadej commented Oct 21, 2024

Could you add a simple unit test either in C++ or even better in pytest to just run this code? That's just to make sure it doesn't spontaneously break.

Of course, which test file would fit it the best?

@ntadej
Copy link
Contributor Author

ntadej commented Oct 22, 2024

I added the test to test_detectors.py.

It seems that linux_ubuntu_2204_clang failure is unrelated but let me know if this is not the case. Otherwise the MR seems to be ready.

@ntadej ntadej requested a review from paulgessinger October 22, 2024 11:39
@andiwand andiwand added this to the next milestone Oct 22, 2024
Copy link

sonarqubecloud bot commented Nov 1, 2024

@kodiakhq kodiakhq bot merged commit 37f541d into acts-project:main Nov 1, 2024
44 checks passed
@github-actions github-actions bot removed the automerge label Nov 1, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.4.0 Nov 8, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
…#3765)

This adds simple python bindings to the test framework to convert between global and local coordinates.
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 20, 2024
…#3765)

This adds simple python bindings to the test framework to convert between global and local coordinates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants