Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve TrackParameterHelpers.hpp #3766

Merged
merged 13 commits into from
Oct 24, 2024
Merged

fix: Improve TrackParameterHelpers.hpp #3766

merged 13 commits into from
Oct 24, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Oct 21, 2024 •
edited
Loading

  • unit tests
  • implement addBoundParameters
  • revisit subtractBoundParameters

@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Oct 21, 2024
@andiwand andiwand added this to the next milestone Oct 21, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Event Data Model Track Fitting labels Oct 21, 2024
@github-actions github-actions bot removed the Component - Plugins Affects one or more Plugins label Oct 23, 2024
@andiwand andiwand removed the 🛑 blocked This item is blocked by another item label Oct 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

📊: Physics performance monitoring for b7f4da7

Full contents

physmon summary

@andiwand andiwand marked this pull request as ready for review October 23, 2024 13:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
70.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 6d982d0 into acts-project:main Oct 24, 2024
42 checks passed
@andiwand andiwand deleted the improve-track-param-helpers branch October 24, 2024 07:25
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [6d982d0]

🔴 Some tests have failed!

Please investigate the pipeline!

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsCachedWorkflow
🟢 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🔴 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🔴 test_ActsWorkflowCached
🔴 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_unit_tests

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 24, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.2.0 Oct 24, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
@andiwand @Rosie-Hasan
fix: Improve TrackParameterHelpers.hpp (acts-project#3766)
c2015b0 
- unit tests
- implement `addBoundParameters`
- revisit `subtractBoundParameters`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Event Data Model Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Milestone
v37.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andiwand @acts-project-service @AJPfleger @paulgessinger