Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove TruthSeedSelector from Examples #3808

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Nov 1, 2024

After removing TruthSeedRanges with #3742 we can also safely remove TruthSeedSelector which does very much the same as the ParticleSelector by now.

@andiwand andiwand added this to the next milestone Nov 1, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

📊: Physics performance monitoring for 1afac4d

Full contents

physmon summary

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@andiwand andiwand marked this pull request as ready for review November 2, 2024 07:29
Copy link

sonarqubecloud bot commented Nov 2, 2024

@kodiakhq kodiakhq bot merged commit 52681f7 into acts-project:main Nov 2, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Nov 2, 2024
@andiwand andiwand deleted the ex-remove-truthseedselector branch November 3, 2024 13:00
@paulgessinger paulgessinger modified the milestones: next, v37.4.0 Nov 8, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
After removing `TruthSeedRanges` with acts-project#3742 we can also safely remove `TruthSeedSelector` which does very much the same as the `ParticleSelector` by now.
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 20, 2024
After removing `TruthSeedRanges` with acts-project#3742 we can also safely remove `TruthSeedSelector` which does very much the same as the `ParticleSelector` by now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants