Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow copy of measurements in Examples #3911

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Nov 27, 2024

Adds new capabilities to the Examples' measurement container: copy measurements from one container to the other.

pulled out of #3836

Summary by CodeRabbit

  • New Features

    • Introduced new template methods in the MeasurementContainer class for copying measurements, enhancing usability for measurement duplication.
  • Bug Fixes

    • Removed unnecessary include directives to simplify dependencies.
  • Documentation

    • Updated concept checks in MeasurementConcept to ensure compliance with new measurement requirements.

@andiwand andiwand added this to the next milestone Nov 27, 2024
Copy link

coderabbitai bot commented Nov 27, 2024

Walkthrough

Changes made to the Measurement.hpp and MeasurementConcept.hpp files within the ActsExamples namespace focus on simplifying dependencies and enhancing functionality. The Measurement.hpp file sees the removal of several include directives and the addition of two template methods for copying measurements in the MeasurementContainer class. In MeasurementConcept.hpp, an include directive is also removed, but the concept's structure remains unchanged.

Changes

File Path Change Summary
Examples/Framework/include/ActsExamples/EventData/Measurement.hpp Removed multiple include directives; added copyMeasurement(const OtherDerived& other) and copyMeasurement(const OtherDerived& other, std::size_t Size) methods in MeasurementContainer.
Examples/Framework/include/ActsExamples/EventData/MeasurementConcept.hpp Removed include directive for Acts/EventData/SourceLink.hpp; no changes to the concept logic.

Poem

In the realm of code, changes take flight,
Dependencies trimmed, making it light.
With new methods added, copying's a breeze,
MeasurementContainer now handles with ease.
Simplified paths, concepts refined,
A journey of code, beautifully aligned! ✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Component - Examples Affects the Examples module Event Data Model labels Nov 27, 2024
@andiwand andiwand marked this pull request as ready for review November 27, 2024 09:45
@andiwand andiwand requested a review from stephenswat November 27, 2024 10:40
Copy link

github-actions bot commented Nov 27, 2024

📊: Physics performance monitoring for 9509e5a

Full contents

physmon summary

@kodiakhq kodiakhq bot merged commit 2e74ffa into acts-project:main Nov 27, 2024
44 checks passed
@andiwand andiwand deleted the ex-feat-copy-measurements branch November 27, 2024 13:43
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [2e74ffa]

Build job with this PR failed!

Please investigate the build job for the pipeline!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module Event Data Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants