Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding extra bit to measurment writer #4007

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Jan 9, 2025

This mini-PR adds the extra-bit to the measurement writer.

--- END COMMIT MESSAGE ---

Any further description goes here, @-mentions are ok here!

  • Use a conventional commits prefix: quick summary
    • We mostly use feat, fix, refactor, docs, chore and build types.
  • A milestone will be assigned by one of the maintainers

Summary by CodeRabbit

  • New Features
    • Enhanced identification capabilities by adding an extra ID field to the digitization tree.
    • Introduced additional geometry identifier tracking for more detailed measurement recording.
  • Bug Fixes
    • Updated hash values for several test files to reflect recent changes in their content.

@asalzburger asalzburger added this to the next milestone Jan 9, 2025
Copy link

coderabbitai bot commented Jan 9, 2025

Walkthrough

In the realm of digital measurement recording, a new integer member variable extraID introduced, it has been. Within the DigitizationTree struct of RootMeasurementWriter, this variable initialized to zero is. A new branch in the TTree created for extraID, allowing it to be written to the tree. Modified, the fillIdentification method has been, now setting extraID with geoId.extra(). Enhanced, the identification capabilities of the DigitizationTree are.

Changes

File Change Summary
Examples/Io/Root/src/RootMeasurementWriter.cpp - Added int extraID member variable to DigitizationTree struct
- Created new tree branch for extraID
- Updated fillIdentification method to set extraID using geoId.extra()
Examples/Python/tests/root_file_hashes.txt - Updated hash values for several test files indicating content changes
- Files affected: test_digitization_example[smeared]__measurements.root, test_digitization_example[geometric]__measurements.root, test_digitization_example_input[smeared]__measurements.root, test_digitization_example_input[geometric]__measurements.root, test_root_meas_writer__meas.root

Poem

A new identifier grows, yes,
In branches of data, we progress.
Extra ID, a number so slight,
Reveals secrets hidden from sight. 🌟
Measurement's path, now more clear,
The Force of data, drawing near. 🔍


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f36c32b and 12e7460.

📒 Files selected for processing (1)
  • Examples/Python/tests/root_file_hashes.txt (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • Examples/Python/tests/root_file_hashes.txt
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: docs
  • GitHub Check: linux_ubuntu_extra (ubuntu2204_clang, 20)
  • GitHub Check: macos
  • GitHub Check: linux_ubuntu_extra (ubuntu2204, 20)
  • GitHub Check: linux_ubuntu
  • GitHub Check: unused_files
  • GitHub Check: missing_includes
  • GitHub Check: build_debug

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Jan 9, 2025
@asalzburger asalzburger requested a review from andiwand January 9, 2025 13:26
andiwand
andiwand previously approved these changes Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

📊: Physics performance monitoring for 041e27b

Full contents

physmon summary

@asalzburger
Copy link
Contributor Author

Hi @andiwand this needed of course an update of the root hashes.

@asalzburger asalzburger requested a review from andiwand January 9, 2025 14:15
Copy link

sonarqubecloud bot commented Jan 9, 2025

@kodiakhq kodiakhq bot merged commit d7a5c22 into acts-project:main Jan 9, 2025
42 checks passed
@github-actions github-actions bot removed the automerge label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants