Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena Fix, main branch (2023.11.15.) #487

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

krasznaa
Copy link
Member

Link traccc::performance explicitly against ${CMAKE_DL_LIBS}. This is necessary on some platforms to be able to use the NVTX code properly. Most notably, I bumped into this while building the project on top of Athena-main-x86_64-centos7-gcc11-opt. 😉

@krasznaa krasznaa added bug Something isn't working cuda Changes related to CUDA labels Nov 15, 2023
@krasznaa krasznaa requested a review from beomki-yeo November 15, 2023 13:11
@krasznaa
Copy link
Member Author

Quite clearly there is yet another race condition still somewhere in our tests. 😦

687/725 Test #689: KalmanFitWireChamberValidation0/KalmanFittingWireChamberTests.Run/("2_GeV", { 0, 0, 0 }, { 0, 0, 0 }, { 2, 2 }, { -1, 1 }, { 0, 6.28319 }, 100, 100) ...................................................................................................................................................***Failed    1.04 sec
Running main() from /__w/traccc/traccc/build/_deps/googletest-src/googletest/src/gtest_main.cc
Note: Google Test filter = KalmanFitWireChamberValidation0/KalmanFittingWireChamberTests.Run/0
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from KalmanFitWireChamberValidation0/KalmanFittingWireChamberTests
[ RUN      ] KalmanFitWireChamberValidation0/KalmanFittingWireChamberTests.Run/0
unknown file: Failure
C++ exception with description "[json.exception.parse_error.101] parse error at line 31632, column 42: syntax error while parsing array - unexpected end of input; expected ']'" thrown in the test body.
[  FAILED  ] KalmanFitWireChamberValidation0/KalmanFittingWireChamberTests.Run/0, where GetParam() = ("2_GeV", { 0, 0, 0 }, { 0, 0, 0 }, { 2, 2 }, { -1, 1 }, { 0, 6.28319 }, 100, 100) (142 ms)
[----------] 1 test from KalmanFitWireChamberValidation0/KalmanFittingWireChamberTests (142 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (948 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] KalmanFitWireChamberValidation0/KalmanFittingWireChamberTests.Run/0, where GetParam() = ("2_GeV", { 0, 0, 0 }, { 0, 0, 0 }, { 2, 2 }, { -1, 1 }, { 0, 6.28319 }, 100, 100)

 1 FAILED TEST

@beomki-yeo
Copy link
Contributor

I thought it was fixed in #484
I changed the SetUp to SetUpTestCase to avoid the racing but it was not working as I expected

@beomki-yeo
Copy link
Contributor

I think the error is caused because multiple tests are trying to create and read back the geometry file at the same time

@krasznaa krasznaa force-pushed the AthenaFix-main-20231115 branch from 1bd2e72 to 1fb0cd5 Compare January 16, 2024 08:42
This is necessary on some platforms to be able to use the NVTX
code properly.
@krasznaa krasznaa force-pushed the AthenaFix-main-20231115 branch from 1fb0cd5 to 1168a72 Compare January 16, 2024 13:12
@krasznaa krasznaa merged commit 425d57e into acts-project:main Jan 16, 2024
18 checks passed
@krasznaa krasznaa deleted the AthenaFix-main-20231115 branch January 16, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda Changes related to CUDA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants