traccc::device::make_barcode_sequence Fix, main branch (2024.02.14.) #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of the two views may be different. (Though their capacities should be the same at all times in the current implementation.) It is the "input view" that we need to respect the size of. The "output view" would be asserted to be big enough.
krasznaa
force-pushed
the
BarcodeSequenceFix-main-20240213
branch
from
f3f8bdd to
c3d3921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the logic in the device function, after finding a bug in it during the debugging of #513.
While we put the "unique measurements" at the beginning of the
uniquesvector/view, the size of the vector/view is not updated. 🤔 It is allowed to be larger than the size of the barcodes vector. (Which will be exactly the size of the number of unique measurements.)Later on we may want to do this in a smarter way, making the measurement buffer update its size properly. But for now this should be good enough. 🤔