-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ambiguity Resolution Performance Writer #521
Add Ambiguity Resolution Performance Writer #521
Conversation
I am not very inclined to add new writers At some point, |
I understand, the less redundant code the better! I will try to merge the |
ffa542e
to
b3f8cf2
Compare
If you find the modification appropriate, I will rebase this branch with the main branch later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formally/technically I'm okay with these changes. But I'll wait for @beomki-yeo's decision... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well
b3f8cf2
to
0386d73
Compare
0386d73
to
8c616af
Compare
Performance writer for the
Greedy Ambiguity Resolution Algorithm
, to be used withROOT
visualizer.I started the implementation by copying and modifying the
finding_performance_writer.hpp/cpp
files, adapting them to thegreedy ambiguity resolution algorithm
.