Improved error reporting for greedy solver

[SylvainJoube]

A few tings:

• Disabled info messages from the greedy solver to avoid distracting the user from important warning and error messages.
• Added an error message when every measurement.measurement_id equals zero:

ERROR: @greedy_ambiguity_resolution_algorithm: Measurements must have unique IDs. But here, each measurement has 0 as ID (measurement.measurement_id == 0). This may be solved by loading measurement_id from the appropriate file, or by assigning a unique ID to each new measurement during CCA.

• Added a warning message when too many measurements share the ID 0. It now says, for example:

"WARNING @greedy_ambiguity_resolution_algorithm: 14% of input measurements have an ID equal to 0 (measurement.measurement_id == 0). This may be suspicious."

• Fixed a minor typo.

[krasznaa]

A little later I'll very much want to review / revise what we do for log messages in all of these algorithms. But for now I'm happy with printing at least fewer messages.

We should just think of whether "flood" messages, with INFO: message lines are the things that we want to go for in the meanwhile. 🤔

[krasznaa]

I'm generally not the biggest fan of all of these output messages. 🤔 But as long as we use them, why not name this as either a DEBUG or VERBOSE output level? To be a bit more in line with Athena / Python / etc. message logging conventions.

[SylvainJoube]

Thanks for your review :)

I made a mistake, I meant to say FLOOD: for "flood" messages. I completely agree with you, I think it's much better to have a common vocabulary and not confuse developers with too many different names referring to the same concept. I’ve changed FLOOD into DEBUG (since I only used these messages for debugging purposes). They are here to help me in case anything goes wrong and I need to debug the code, but I agree, the fewer messages we print on the terminal, the better, and there is no point in repeatedly saying "I'm doing this and that, everything works fine", better save space for the really important messages.

[krasznaa]

👍