Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODD ttbar Clusterization Fix, main branch (2024.05.04.) #566

Merged

Conversation

krasznaa
Copy link
Member

@krasznaa krasznaa commented May 4, 2024

Made high-$\mu$ ODD ttbar samples succeed with (device) clusterization.

As discussed in #565, with $\mu$ = 100 and higher, on the files that I generated as described in #561, I had to do this to avoid running into assertion errors from the clusterization code. 🤔

I'm very open to discussions about why this is, but the code, with its current logic of how it splits the cells into partitions, does need this update for the highest pileup ODD simulations.

@krasznaa krasznaa added cuda Changes related to CUDA improvement Improve an existing feature sycl Changes related to SYCL labels May 4, 2024
@krasznaa krasznaa requested a review from stephenswat May 4, 2024 10:20
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is, of course, a perfectly fine change to make. Just note that the trade-off here is that increasing this parameter is expected to decrease occupancy and, as a result, performance. But that's something we can figure out later.

@stephenswat stephenswat enabled auto-merge (rebase) May 4, 2024 10:55
@stephenswat stephenswat merged commit 12103b3 into acts-project:main May 4, 2024
17 of 18 checks passed
@krasznaa krasznaa deleted the ODDttbarClusterization-main-20240504 branch May 4, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda Changes related to CUDA improvement Improve an existing feature sycl Changes related to SYCL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants