Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more branches in the ckf matching rate test #570

Merged
merged 1 commit into from
May 5, 2024

Conversation

beomki-yeo
Copy link
Contributor

This test is failing after #563.

There seems to be almost identical twin tracks thanks to the poor random generator, therefore, the max number of branches per seed should increase in this specific test (10->500).

If one asks why it didn't fail before #563, max_num_branches_per_seed was the max value.

@beomki-yeo beomki-yeo force-pushed the more-branches-allowed branch from ca545eb to 0297b05 Compare May 4, 2024 14:08
@beomki-yeo beomki-yeo requested a review from krasznaa May 4, 2024 23:18
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@krasznaa krasznaa force-pushed the more-branches-allowed branch from 0297b05 to 689eea8 Compare May 5, 2024 06:07
@krasznaa krasznaa merged commit 0be7b80 into acts-project:main May 5, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants