Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in CUDA barrier unit test #619

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

stephenswat
Copy link
Member

@stephenswat stephenswat commented Jun 18, 2024

This fixes an embarassing bug in #610 where I had apparently mass-changed barrierCount into barrierOr. Oops!

@stephenswat stephenswat added bug Something isn't working tests Make sure the code keeps working cuda Changes related to CUDA labels Jun 18, 2024
@stephenswat stephenswat requested a review from krasznaa June 18, 2024 15:13
This fixes an embarassing bug in acts-project#610 where I had apparently
mass-changed `barrierCount` into `barrierOr`. Oops!
@stephenswat stephenswat force-pushed the fix/cuda_barrier_test branch from df417a4 to 7191b6c Compare June 18, 2024 15:14
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the PR's description. (It's currently the same as for #618.)

But just as #618, this is also needed for #616.

@stephenswat stephenswat enabled auto-merge June 18, 2024 15:17
@stephenswat stephenswat merged commit d4cad96 into acts-project:main Jun 18, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda Changes related to CUDA tests Make sure the code keeps working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants