Download data files after build in CI #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it stands right now, we download all the data files before we ever even build the traccc project. This is a bit wasteful, as a failed build will render all that downloading useless. This commit moves the data downloading step to after the build step, and also makes it conditional on whether the tests will actually be run.
stephenswat
added
cicd
|
Note: this used to work fine when the data files were several megabytes; now they are gigabytes! |
krasznaa
approved these changes
Jun 26, 2024
paulgessinger
approved these changes
Jun 26, 2024
Both work, I'd struggle to make any reasonable argument one way or the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands right now, we download all the data files before we ever even build the traccc project. This is a bit wasteful, as a failed build will render all that downloading useless. This commit moves the data downloading step to after the build step, and also makes it conditional on whether the tests will actually be run.