Simplify ODD Strip Module Handling, main branch (2024.08.20.) #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
approved these changes
Aug 20, 2024
beomki-yeo
approved these changes
Aug 20, 2024
As it turned out, there was no reason to keep this variable in memory. The values coming from the digitization files were the same as what we get with the formula implemented in the measurement creation code. At the same time made the code for detecting 1D modules a lot more robust. Now the decision is made based on the number of "bins" in a module's segmentation.
krasznaa
force-pushed
the
SimplifyStrips-main-20240819
branch
from
6f3ee1a to
513eb04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
traccc::pixel_data::variance_yvariable. As discussed in #627 (comment), there was no reason to keep this variable in memory. The values coming from the digitization files were the same as what we get with the formula implemented in the measurement creation code.At the same time made the code for detecting 1D modules a lot more robust. Now the decision is made based on the number of "bins" in a module's segmentation.
I tested on our multi-muon ODD simulations that these changes don't affect the output of
traccc_seq_example. (While also testing that for instance setting all modules to be 2D would have a visible effect.)I wanted to put this in before making the same simplification in #627 as well. 🤔