Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Update to detray version 0.75.2 #703

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

niermann999
Copy link
Contributor

This integrates a new library detray::test_utils that contains headers that are useful for testing. The bfield creation and detector types have been moved to detray::detectors. Both was previously packaged in detray::utils

@stephenswat
Copy link
Member

Do you mean 0.75.0? I don't think 0.75.1 exists (yet).

@niermann999

This comment was marked as outdated.

@niermann999 niermann999 marked this pull request as ready for review September 19, 2024 11:29
@niermann999 niermann999 changed the title ref: Update to detray version 0.75.1 ref: Update to detray version 0.75.2 Sep 19, 2024
@niermann999

This comment was marked as outdated.

@asalzburger
Copy link
Contributor

There is still a build failure?

@niermann999
Copy link
Contributor Author

There is still a build failure?

No, it is an assertion that fails, fixed in acts-project/detray#819.

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will update ACTS with traccc and detray then.

extern/detray/CMakeLists.txt Show resolved Hide resolved
@asalzburger asalzburger merged commit 5782636 into acts-project:main Sep 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants