Update to VecMem 1.9.0, main branch (2024.09.30.) #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the same time set the minimum version to 1.8.0, and changed how vecmem's CMake code would be picked up in this project.
krasznaa
force-pushed
the
VecMemUpdate-main-20240930
branch
from
7e8c3e4 to
02a7676
Compare
beomki-yeo
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded the project to using vecmem-1.9.0.
At the same time set the minimum version to
1.8.0, and changed how vecmem's CMake code would be picked up in this project.This PR is a required input for #712. Note that I'll set the minimum required version of vecmem to
1.9.0in that PR. In this one I went with1.8.0, as for the current state of this project, that's the actual minimum required. (Once this PR is in. It's a longer story...)