Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the particle hypo of KF in case of charge is changed #731

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

beomki-yeo
Copy link
Contributor

@stephenswat Can you test this if it does work? Otherwise please let me know the command line so I can reproduce

@beomki-yeo beomki-yeo requested a review from stephenswat October 7, 2024 14:21
Copy link

sonarqubecloud bot commented Oct 7, 2024

@stephenswat stephenswat linked an issue Oct 7, 2024 that may be closed by this pull request
@stephenswat stephenswat added the bug Something isn't working label Oct 7, 2024
@stephenswat
Copy link
Member

I tested this, but now the CKF seems to run forever... Very odd!

@beomki-yeo
Copy link
Contributor Author

You mean KF runs forever? Or is this something independent

@beomki-yeo
Copy link
Contributor Author

With this PR, I can run mt_cuda with ODD mu200 data (RelWithDebInfo build). Probably you need to wait a couple of minute because it took about 2 mins for warming up

Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then I'm happy. Thanks!

@stephenswat stephenswat merged commit 3f1dc9e into acts-project:main Oct 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kalman Fitter Changes the Charge of Tracks Unexpectedly
2 participants