Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put CKF tips into a single vector #740

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Put CKF tips into a single vector #740

merged 1 commit into from
Oct 16, 2024

Conversation

stephenswat
Copy link
Member

Currently, we unnecessarily put tips into a jagged vector-like structure; this commit turns this into a single, resizable array to save on copies and to make the code a bit simpler.

@stephenswat stephenswat added refactor Change the structure of the code cuda Changes related to CUDA labels Oct 15, 2024
krasznaa
krasznaa reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your proposal looks sound to me. But Beomki will have to give the final say on this one.

device/cuda/src/finding/finding_algorithm.cu Outdated Show resolved Hide resolved
device/cuda/src/finding/finding_algorithm.cu Show resolved Hide resolved
beomki-yeo
beomki-yeo approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think I could not come up with this because max_num_branches_per_seed is introduced by Shima later.

@stephenswat stephenswat force-pushed the refactor/ckf_cleanup_2 branch from df939e2 to 3134b9b Compare October 16, 2024 13:55
@stephenswat stephenswat enabled auto-merge October 16, 2024 13:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stephenswat
Put CKF tips into a single vector
3134b9b 
Currently, we unnecessarily put tips into a jagged vector-like
structure; this commit turns this into a single, resizable array to save
on copies and to make the code a bit simpler.
@stephenswat stephenswat merged commit 97b21b8 into acts-project:main Oct 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasznaa krasznaa krasznaa left review comments

@beomki-yeo beomki-yeo beomki-yeo approved these changes

Assignees
No one assigned
Labels
cuda Changes related to CUDA refactor Change the structure of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenswat @krasznaa @beomki-yeo