Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default value of chi2 max to 10 #743

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Change the default value of chi2 max to 10 #743

merged 2 commits into from
Oct 17, 2024

Conversation

beomki-yeo
Copy link
Contributor

@beomki-yeo beomki-yeo commented Oct 17, 2024 •
edited
Loading

This seems to be the good number for ODD. The current value of 30 finds 3 times more tracks from CKF with almost same tracking effieicny

krasznaa
krasznaa approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@beomki-yeo beomki-yeo merged commit 12ae313 into acts-project:main Oct 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasznaa krasznaa krasznaa approved these changes

@stephenswat stephenswat Awaiting requested review from stephenswat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beomki-yeo @krasznaa