Update Presets, main branch (2024.10.25.) #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
force-pushed
the
UpdatePresets-main-20241025
branch
from
f7081fd to
cc55256
Compare
|
Turns out, we were not building the benchmarks in the CI so far. 😱 While at it, I also added a 64-bit build of the host code. For the device libraries I didn't add such things, but we could consider doing so at one point... 🤔 Generally the PR is now ready to be looked at. 😉 |
krasznaa
force-pushed
the
UpdatePresets-main-20241025
branch
2 times, most recently
from
862d28f to
dcd0c1d
Compare
beomki-yeo
reviewed
Oct 28, 2024
Also removed the c++ standard configurability from the GitHub CI, as we only (really) support C++20 at the moment in this project.
I wanted that to serve as a nudge for making the CUDA-enabled variants of those builds functional, but for the CI it is just causing more trouble than it's worth at the moment.
krasznaa
force-pushed
the
UpdatePresets-main-20241025
branch
from
825159c to
8b970fe
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-designed the project's build presets a little.
arrayandeigenpresets, as even I never used those so far;full-fp32/full-fp64presets, which attempt to build everything that the repository has to offer, at the same time.Technically a lot more combinations could still be added. But I thought this may be the golden middle ground between not having enough variety, and having too much. 🤔
I'm also pondering about reforming our CI setup a little. 🤔 More may very well come to this PR soon...