-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fitting performance writer by changing the measurement comparator #754
Conversation
a891412
to
c7faa26
Compare
f18dfb1
to
7edadd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No big objections on my part, just the two technical questions/suggestions...
7edadd5
to
a358a1b
Compare
a358a1b
to
8dd31a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest I'm happy with.
And if you push back firmly enough about the whole std::map::insert
point, I can drop that as well. Since your code technically already works correctly like this as well. 😉
43dd5e1
to
8554578
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
The measurement comparison operator with
float_epsilon
is causing a bug inevent_data
. When the difference between the new measurement and one in the map is bigger thanfloat_epsilon
, the measurement is not added to the map.(You can find the simple code that reproduces this behavior: https://godbolt.org/z/3hP9P5Eo9)
I fixed the issue by removing the
float_epsilon
. Also putat
instead of[]
wherever possible to make sure that there is the measurement in the map