De-Template the SYCL Library, main branch (2024.11.01.) #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
added
build
krasznaa
force-pushed
the
DeTemplateSYCL-main-20241030
branch
from
1554db0 to
66fc83d
Compare
krasznaa
force-pushed
the
DeTemplateSYCL-main-20241030
branch
3 times, most recently
from
ade087f to
e06f537
Compare
|
@stephenswat, @beomki-yeo, @paulgessinger, any comments? This is not the be-all / end-all yet. As I told @stephenswat yesterday, I have some ideas of how to expose the underlying kernels in the API of the device libraries, but I'd like to separate that from this PR. As I'll first want to add SYCL track finding, once this one goes in. 🤔 |
In the same way as I did for traccc::host::silicon_pixel_spacepoint_formation_algorithm earlier.
krasznaa
force-pushed
the
DeTemplateSYCL-main-20241030
branch
from
e06f537 to
f006724
Compare
|
stephenswat
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following in the footsteps of #756 and #749, here I want to make the two SYCL algorithms that currently have a template parameter, not have one. 🤔
The logic is exactly the same as in the previous PRs. I make the algorithms deal only with specific detector and magnetic field types, and use a specific setup for track fitting in the case of
traccc::sycl::kalman_fitting_algorithm.I wanted to do this before finally introducing a CKF algorithm for SYCL. Since technically we should be able to make that work since a while...