Parallelize Cell Reading For Throughput Measurements, main branch (2024.11.09.) #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
added
performance
|
😕 I could not disagree more with SonarCloud on this one.
Why should it be obvious to the reader that |
beomki-yeo
approved these changes
Nov 11, 2024
krasznaa
force-pushed
the
ParallelizeCellReading-main-20241109
branch
from
43b21d1 to
c2d8255
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that I had in the back of my mind ever since running the throughput tests for @beomki-yeo's CHEP 2024 results. But until now I thought that I should do this in
traccc::io, by reviving the same style of function that we had back in the day with OpenMP.But I had to realize that the throughput application itself, where this is actually relevant, already has everything available to parallelize its own file reading. 🤔 So I just used the simplest API of TBB, tbb::parallel_for. 😉
On my home PC it for instance brings down the reading of 500 mu=140 ODD events from almost 4 minutes to ~10 seconds. (Yepp, Threadripper still FTW. 😛)