Acts Seed-Finding Comparison Update, main branch (2024.11.13.) #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
force-pushed
the
UpdateSeedingTest-main-20241113
branch
from
9d2c626 to
fca9218
Compare
CarloVarni
reviewed
Nov 13, 2024
With the latest Acts version it's not necessary to create a dummy SpacePoint class anymore. We can put a wrapper around traccc::spacepoint directly. At the same time simplified / cleaned the code a little. Thanks to Carlo for his suggestions!
krasznaa
force-pushed
the
UpdateSeedingTest-main-20241113
branch
from
fca9218 to
a12397e
Compare
|
CarloVarni
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by #765, this PR tries to simplify the comparison code a little bit.
With the latest Acts version it's not necessary to create a dummy
SpacePointclass anymore. We can put a wrapper aroundtraccc::spacepointdirectly. So this is what I did. At this point we can just use the existing==operator fortraccc::spacepointas well.At the same time I simplified / cleaned the code a little, so that it would be more to my liking...