-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Count the number of holes in the KF #778
Conversation
Don't we already have the hole count form the CKF? Why do we need to recalculate it in the KF? |
I added it because CKF and KF may have different propagation setup (particle hypothesis, navigator config, etc.). The propagation of CKF also stops if the number of holes hit a certain number ( |
97ddeae
to
acec9af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, thank you for the explanation.
OK I didn't change the propagator algorithm and KF and CKF might yield the same result for the holes. But it is not bad to have the hole counting in KF in case we combine with other track finding methods that don't do any hole counting (e.g. GNN...) |
Quality Gate passedIssues Measures |
Based on #774
The number of holes will be required in the ambiguity solver.
To count the number of holes even after all track candidates are visited, the abort condition in the KF is removed. This will increase the CPU computing time but impact on the GPU KF will be much smaller.
Also added a test to make sure the new feature works correctly