Some typescript migration #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
MatissJanis
reviewed
Aug 17, 2023
| @@ -0,0 +1,181 @@ | |||
| import React, { useEffect, useState } from 'react'; | |||
There was a problem hiding this comment.
This file has quite a lot of functional changes (you're porting it from a class component to a hook). Any chance you could do this as a separate PR so we can carefully review the changes?
There was a problem hiding this comment.
Reverted the changes here and created a separate PR for the ported components: #1535
| @@ -0,0 +1,194 @@ | |||
| import React, { useState } from 'react'; | |||
There was a problem hiding this comment.
Same comment about this component.
There was a problem hiding this comment.
Reverted the changes here and created a separate PR for the ported components: #1535
packages/desktop-client/src/components/sidebar/SecondaryItem.tsx
Outdated
Show resolved
Hide resolved
MatissJanis
reviewed
Aug 17, 2023
|
Apart from that one comment everything else looks good. 👍 |
MatissJanis
approved these changes
Aug 17, 2023
trafico-bot
bot
added
✨ Merged
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
* Typescript migration * Release notes * Update error boundary * Breakup sidebar components * Account and Sidebar props * Remove button in Item component + exports cleanup * Put accountNameStyle to Account * Revert component ports (separated to another PR) * Export cleanup * Remove ErrorBoundary (separated to another PR) * Sidebar budgetName as ReactNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some typescript migration for components in the root components directory. Also moved some sidebar components to the sidebar folder. There's no functional change in this PR.
This is to help with #1483.