Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor budget/MobileTable to tsx #1602

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Refactor budget/MobileTable to tsx #1602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f356b33
refactor budget/MobileTable to tsx
Jod929 Aug 28, 2023
20c5e4f
add release notes for MobileTable refactor
Jod929 Aug 28, 2023
4a1dd67
update MobileTable to iclude props spread to View
Jod929 Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ...ient/src/components/budget/MobileTable.js → ...ent/src/components/budget/MobileTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,20 @@
import React from 'react';
import React, {
type ComponentProps,
type CSSProperties,
type ReactNode,
} from 'react';

import { colors } from '../../style';
import View from '../common/View';

export const ROW_HEIGHT = 50;

export const ListItem = ({ children, style, ...props }) => {
type ListItemProps = ComponentProps<typeof View> & {
children?: ReactNode;
style: CSSProperties;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 suggestion: ‏should also add ViewProps for the props that got spread and passed to View component.

Suggested change
};
} & ViewProps;


export const ListItem = ({ children, style, ...props }: ListItemProps) => {
return (
<View
style={[
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/1602.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [Jod929]
---

Refactor MobileTable to tsx.