Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 removing privacyMode feature flag #1688

Merged
merged 2 commits into from
Sep 12, 2023
Merged

🔥 removing privacyMode feature flag #1688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
912cfd5
:fire: removing privacyMode feature flag
MatissJanis Sep 11, 2023
16479fe
Release notes
MatissJanis Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/desktop-client/src/components/PrivacyFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import React, {

import usePrivacyMode from 'loot-core/src/client/privacy';

import useFeatureFlag from '../hooks/useFeatureFlag';
import { useResponsive } from '../ResponsiveProvider';

import View from './common/View';
Expand Down Expand Up @@ -53,7 +52,6 @@ export default function PrivacyFilter({
children,
...props
}: PrivacyFilterProps) {
let privacyModeFeatureFlag = useFeatureFlag('privacyMode');
let privacyMode = usePrivacyMode();
// Limit mobile support for now.
let { isNarrowWidth } = useResponsive();
Expand All @@ -67,7 +65,7 @@ export default function PrivacyFilter({

let blurAmount = blurIntensity != null ? `${blurIntensity}px` : '3px';

return !privacyModeFeatureFlag || !activate ? (
return !activate ? (
<>{Children.toArray(children)}</>
) : (
<BlurredOverlay blurIntensity={blurAmount} {...props}>
Expand Down
3 changes: 1 addition & 2 deletions packages/desktop-client/src/components/Titlebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,6 @@ export default function Titlebar({ style }) {
state => state.prefs.global.floatingSidebar,
);

let privacyModeFeatureFlag = useFeatureFlag('privacyMode');
let themesFlag = useFeatureFlag('themes');

return isNarrowWidth ? null : (
Expand Down Expand Up @@ -369,7 +368,7 @@ export default function Titlebar({ style }) {
<View style={{ flex: 1 }} />
<UncategorizedButton />
{themesFlag && <ThemeSelector />}
{privacyModeFeatureFlag && <PrivacyButton />}
<PrivacyButton />
{serverURL ? <SyncButton style={{ marginLeft: 10 }} /> : null}
<LoggedInUser style={{ marginLeft: 10 }} />
</View>
Expand Down
1 change: 0 additions & 1 deletion packages/desktop-client/src/components/settings/Experimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ export default function ExperimentalFeatures() {
Goal templates
</FeatureToggle>

<FeatureToggle flag="privacyMode">Privacy mode</FeatureToggle>
<FeatureToggle flag="experimentalOfxParser">
Experimental OFX parser
</FeatureToggle>
Expand Down
1 change: 0 additions & 1 deletion packages/desktop-client/src/hooks/useFeatureFlag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const DEFAULT_FEATURE_FLAG_STATE: Record<FeatureFlag, boolean> = {
categorySpendingReport: false,
reportBudget: false,
goalTemplatesEnabled: false,
privacyMode: true,
themes: false,
experimentalOfxParser: true,
};
Expand Down
1 change: 0 additions & 1 deletion packages/loot-core/src/types/prefs.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ export type FeatureFlag =
| 'categorySpendingReport'
| 'reportBudget'
| 'goalTemplatesEnabled'
| 'privacyMode'
| 'themes'
| 'experimentalOfxParser';

Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/1688.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [MatissJanis]
---

Remove `privacyMode` feature flag as this feature is GA