Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more information in payee of split parent #3049

Conversation

jfdoming
Copy link
Contributor

@jfdoming jfdoming commented Jul 13, 2024

Split from #2923

Before:
image

After:
image

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit e262c2d
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6698658d58519d00084820fa
😎 Deploy Preview https://deploy-preview-3049.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jul 13, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.74 MB → 4.74 MB (+2.81 kB) +0.06%
Changeset
File Δ Size
src/components/transactions/TransactionsTable.jsx 📈 +2.96 kB (+5.13%) 57.63 kB → 60.58 kB
src/components/budget/rollover/RolloverComponents.tsx 📉 -154 B (-1.19%) 12.59 kB → 12.44 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide.js 274.25 kB → 277.06 kB (+2.81 kB) +1.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 76.19 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.61 kB 0%
static/js/ReportRouter.js 1.23 MB 0%
static/js/index.js 2.99 MB 0%

Copy link
Contributor

github-actions bot commented Jul 13, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.13 MB 0%

@jfdoming jfdoming changed the title [WIP] Include more information in split payee [WIP] Include more information in payee of split parent Jul 13, 2024
@jfdoming jfdoming force-pushed the jfdoming/include-more-information-in-split-payee branch from 6c391a3 to afbd224 Compare July 13, 2024 21:49
@jfdoming jfdoming changed the title [WIP] Include more information in payee of split parent Include more information in payee of split parent Jul 13, 2024
This was referenced Jul 13, 2024
@youngcw
Copy link
Member

youngcw commented Jul 15, 2024

What do you think about reverting the subdued text for the payee back to the same color as regular lines?

@jfdoming
Copy link
Contributor Author

What do you think about reverting the subdued text for the payee back to the same color as regular lines?

Just for the payee or also the category? IMO the consistency across the two child-derived fields is nice (I could even see us doing something similar to this PR for categories, not sure). But I can see the argument for just payee, since it is now no longer a "special" payee, let me know your thoughts!

@youngcw
Copy link
Member

youngcw commented Jul 17, 2024

I was thinking just the payee field, and the category can stay the color it is. Its not a big deal though.

@jfdoming jfdoming force-pushed the jfdoming/include-more-information-in-split-payee branch from a95b387 to cd41467 Compare July 18, 2024 00:43
@jfdoming jfdoming force-pushed the jfdoming/include-more-information-in-split-payee branch from cd41467 to e262c2d Compare July 18, 2024 00:44
@jfdoming
Copy link
Contributor Author

I think it might make sense to keep it as is, then; my understanding from playing around with the UI is we've been using that grey colour to signify "can't edit this field" and the parent here is indeed not editable

Copy link
Contributor

@joel-jeremy joel-jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It would be awesome to have in mobile view too but we can address in a separate PR. :)

@joel-jeremy joel-jeremy merged commit a970a78 into actualbudget:master Jul 20, 2024
19 checks passed
@jfdoming jfdoming deleted the jfdoming/include-more-information-in-split-payee branch August 3, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants