-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include more information in payee of split parent #3049
Include more information in payee of split parent #3049
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
6c391a3
to
afbd224
Compare
What do you think about reverting the subdued text for the payee back to the same color as regular lines? |
Just for the payee or also the category? IMO the consistency across the two child-derived fields is nice (I could even see us doing something similar to this PR for categories, not sure). But I can see the argument for just payee, since it is now no longer a "special" payee, let me know your thoughts! |
I was thinking just the payee field, and the category can stay the color it is. Its not a big deal though. |
a95b387
to
cd41467
Compare
cd41467
to
e262c2d
Compare
I think it might make sense to keep it as is, then; my understanding from playing around with the UI is we've been using that grey colour to signify "can't edit this field" and the parent here is indeed not editable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It would be awesome to have in mobile view too but we can address in a separate PR. :)
Split from #2923
Before:
After: