Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 ping WIP PRs that have been inactive for a week #3107

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

MatissJanis
Copy link
Member

We have quite a few PRs in the backlog that are marked as "WIP". I'm not sure if they are actually WIP or if the authors simply didn't know they should remove the "WIP" prefix for the PR to be reviewed.

Either way - adding a small automation that will ping WIP PRs that have been inactive for a week. Hopefully that will help unblock some of these PRs.

@actual-github-bot actual-github-bot bot changed the title 🔧 ping WIP PRs that have been inactive for a week [WIP] 🔧 ping WIP PRs that have been inactive for a week Jul 20, 2024
Copy link

netlify bot commented Jul 20, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit f8d1c64
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/669bb159217e10000807c362
😎 Deploy Preview https://deploy-preview-3107.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MatissJanis MatissJanis changed the title [WIP] 🔧 ping WIP PRs that have been inactive for a week 🔧 ping WIP PRs that have been inactive for a week Jul 20, 2024
Copy link
Contributor

github-actions bot commented Jul 20, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.79 MB → 4.74 MB (-51.45 kB) -1.05%
Changeset
File Δ Size
src/components/Modals.tsx 📈 +1.13 kB (+8.06%) 13.96 kB → 15.08 kB
src/components/common/Modal.tsx 📈 +715 B (+7.83%) 8.92 kB → 9.62 kB
src/components/FatalError.tsx 📉 -2 B (-0.03%) 6.8 kB → 6.8 kB
src/components/manager/DeleteFile.tsx 📉 -2 B (-0.05%) 4.15 kB → 4.14 kB
src/components/manager/Import.tsx 📉 -2 B (-0.06%) 3.38 kB → 3.38 kB
src/components/manager/ImportActual.tsx 📉 -2 B (-0.06%) 3.37 kB → 3.37 kB
src/components/manager/ImportYNAB5.tsx 📉 -2 B (-0.07%) 3 kB → 3 kB
src/components/manager/ImportYNAB4.tsx 📉 -2 B (-0.07%) 2.98 kB → 2.98 kB
src/components/modals/MergeUnusedPayees.jsx 📉 -45 B (-0.70%) 6.27 kB → 6.22 kB
src/components/modals/ImportTransactions.jsx 📉 -1.02 kB (-2.04%) 49.93 kB → 48.92 kB
src/components/mobile/budget/BudgetTable.jsx 📉 -1.22 kB (-2.40%) 50.94 kB → 49.72 kB
src/components/modals/EditRule.jsx 📉 -1.37 kB (-3.82%) 35.93 kB → 34.56 kB
src/components/schedules/ScheduleDetails.jsx 📉 -1.21 kB (-4.20%) 28.86 kB → 27.65 kB
src/components/modals/SelectLinkedAccounts.jsx 📉 -327 B (-4.46%) 7.17 kB → 6.85 kB
src/components/modals/EditField.jsx 📉 -447 B (-5.77%) 7.57 kB → 7.13 kB
src/components/modals/GoCardlessExternalMsg.tsx 📉 -538 B (-5.86%) 8.97 kB → 8.44 kB
src/components/mobile/budget/index.tsx 📉 -602 B (-6.09%) 9.65 kB → 9.06 kB
src/components/schedules/DiscoverSchedules.tsx 📉 -443 B (-6.49%) 6.66 kB → 6.23 kB
src/components/modals/CreateEncryptionKeyModal.tsx 📉 -677 B (-7.90%) 8.37 kB → 7.71 kB
src/components/modals/CategoryGroupMenuModal.tsx 📉 -520 B (-8.23%) 6.17 kB → 5.66 kB
src/components/modals/CategoryMenuModal.tsx 📉 -451 B (-8.24%) 5.34 kB → 4.9 kB
src/components/modals/FixEncryptionKeyModal.tsx 📉 -493 B (-8.39%) 5.74 kB → 5.26 kB
src/components/modals/CreateAccountModal.tsx 📉 -1.25 kB (-8.56%) 14.57 kB → 13.32 kB
src/components/modals/AccountMenuModal.tsx 📉 -474 B (-8.85%) 5.23 kB → 4.77 kB
src/components/modals/CloseAccountModal.tsx 📉 -1020 B (-10.71%) 9.3 kB → 8.31 kB
src/components/modals/RolloverBudgetMonthMenuModal.tsx 📉 -662 B (-11.33%) 5.7 kB → 5.06 kB
src/components/modals/ReportBudgetMonthMenuModal.tsx 📉 -646 B (-11.35%) 5.56 kB → 4.93 kB
src/components/modals/CoverModal.tsx 📉 -342 B (-12.21%) 2.74 kB → 2.4 kB
src/components/modals/CreateLocalAccountModal.tsx 📉 -904 B (-12.83%) 6.88 kB → 6 kB
src/components/modals/CategoryAutocompleteModal.tsx 📉 -292 B (-12.84%) 2.22 kB → 1.94 kB
src/components/modals/LoadBackup.jsx 📉 -699 B (-12.91%) 5.29 kB → 4.6 kB
src/components/modals/PayeeAutocompleteModal.tsx 📉 -231 B (-13.14%) 1.72 kB → 1.49 kB
src/components/modals/ReportBudgetMenuModal.tsx 📉 -352 B (-13.16%) 2.61 kB → 2.27 kB
src/components/modals/RolloverBudgetMenuModal.tsx 📉 -354 B (-13.22%) 2.62 kB → 2.27 kB
src/components/modals/ScheduledTransactionMenuModal.tsx 📉 -355 B (-13.39%) 2.59 kB → 2.24 kB
src/components/modals/ConfirmCategoryDelete.tsx 📉 -648 B (-13.46%) 4.7 kB → 4.07 kB
src/components/modals/AccountAutocompleteModal.tsx 📉 -275 B (-13.49%) 1.99 kB → 1.72 kB
src/components/modals/GoCardlessInitialise.tsx 📉 -524 B (-13.64%) 3.75 kB → 3.24 kB
src/components/modals/TransferModal.tsx 📉 -534 B (-14.00%) 3.72 kB → 3.2 kB
src/components/schedules/PostsOfflineNotification.jsx 📉 -523 B (-14.79%) 3.45 kB → 2.94 kB
src/components/modals/KeyboardShortcutModal.tsx 📉 -1.88 kB (-15.23%) 12.31 kB → 10.43 kB
src/components/modals/RolloverBalanceMenuModal.tsx 📉 -378 B (-15.95%) 2.31 kB → 1.95 kB
src/components/modals/ReportBalanceMenuModal.tsx 📉 -372 B (-16.19%) 2.24 kB → 1.88 kB
src/components/schedules/ScheduleLink.tsx 📉 -562 B (-16.36%) 3.36 kB → 2.81 kB
node_modules/@react-aria/overlays/dist/Overlay.mjs 📉 -392 B (-16.55%) 2.31 kB → 1.93 kB
src/components/modals/SimpleFinInitialise.tsx 📉 -486 B (-16.68%) 2.84 kB → 2.37 kB
src/components/modals/BudgetPageMenuModal.tsx 📉 -326 B (-16.72%) 1.9 kB → 1.59 kB
src/components/modals/HoldBufferModal.tsx 📉 -382 B (-17.51%) 2.13 kB → 1.76 kB
src/components/modals/RolloverBudgetSummaryModal.tsx 📉 -529 B (-18.44%) 2.8 kB → 2.29 kB
src/components/modals/ConfirmTransactionEdit.tsx 📉 -661 B (-18.56%) 3.48 kB → 2.83 kB
src/components/modals/SingleInputModal.tsx 📉 -505 B (-19.86%) 2.48 kB → 1.99 kB
src/components/modals/NotesModal.tsx 📉 -473 B (-20.06%) 2.3 kB → 1.84 kB
src/components/modals/BudgetListModal.tsx 📉 -316 B (-21.97%) 1.4 kB → 1.1 kB
src/components/modals/ConfirmTransactionDelete.tsx 📉 -456 B (-25.11%) 1.77 kB → 1.33 kB
src/components/modals/ConfirmUnlinkAccount.tsx 📉 -514 B (-25.30%) 1.98 kB → 1.48 kB
src/components/modals/ReportBudgetSummaryModal.tsx 📉 -465 B (-28.88%) 1.57 kB → 1.12 kB
src/components/modals/ManageRulesModal.tsx 📉 -353 B (-33.62%) 1.03 kB → 697 B
src/components/modals/RolloverToBudgetMenuModal.tsx 📉 -345 B (-36.20%) 953 B → 608 B
node_modules/react-aria-components/dist/Dialog.mjs 📉 -3.06 kB (-96.97%) 3.16 kB → 98 B
src/components/common/Modal2.tsx 🔥 -9.08 kB (-100%) 9.08 kB → 0 B
node_modules/react-aria-components/dist/Modal.mjs 🔥 -6.88 kB (-100%) 6.88 kB → 0 B
node_modules/@react-aria/dialog/dist/useDialog.mjs 🔥 -3.03 kB (-100%) 3.03 kB → 0 B
node_modules/@react-aria/overlays/dist/useModalOverlay.mjs 🔥 -1.35 kB (-100%) 1.35 kB → 0 B
node_modules/react-aria-components/dist/RSPContexts.mjs 🔥 -884 B (-100%) 884 B → 0 B
src/hooks/useModalState.ts 🔥 -657 B (-100%) 657 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 3.04 MB → 2.99 MB (-49.64 kB) -1.60%
static/js/narrow.js 78 kB → 76.19 kB (-1.81 kB) -2.32%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.61 kB 0%
static/js/wide.js 274.1 kB 0%
static/js/ReportRouter.js 1.23 MB 0%

Copy link
Contributor

github-actions bot commented Jul 20, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.13 MB 0%

@MatissJanis MatissJanis merged commit 9a85a72 into master Jul 20, 2024
19 checks passed
@MatissJanis MatissJanis deleted the matiss/stale-prs branch July 20, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants