[WIP] Translation: desktop-client/src/components/budget/BudgetTotals.tsx #3367
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
| @@ -54,11 +56,11 @@ export const BudgetTotals = memo(function BudgetTotals({ | |||
| WebkitUserSelect: 'none', | |||
| }} | |||
| > | |||
| <View style={{ flexGrow: '1' }}>Category</View> | |||
| <View style={{ flexGrow: '1' }}>{t('Category')}</View> | |||
There was a problem hiding this comment.
Looks good now! Sorry for one last comment, the convention we've been using in the rest of the code base for components is to use <Trans>. I.e.:
| <View style={{ flexGrow: '1' }}>{t('Category')}</View> | |
| <View style={{ flexGrow: '1' }}><Trans>Category</Trans></View> |
You'll need to import it as well
There was a problem hiding this comment.
Yeah there are discussion around those to different stage on discord. I did see real statement yet but I'm might be wrong, that why I use the lazy way using one unique code style :p
However reading the doc it is clearer for me I have to use component in some cases: https://actualbudget.org/docs/contributing/i18n
I'll rework the file. Thanks for your heads up.
…mponents/budget/BudgetTotals.tsx
…tsx (actualbudget#3367) * i18 translation * realease note * translate 'arial-label' text * translate 'text' * fixing 'text' translation * <Trans> component for HTML tag * Lint --------- Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>
Translation support for: desktop-client/src/components/budget/BudgetTotals.tsx