[DO NOT MERGE] Symbols as weakmap keys - Stage 2 draft changes
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specification PR for https://github.com/tc39/proposal-symbols-as-weakmap-keys Note that both registered and unregistered Symbols are permitted here. Closes tc39#1194
acutmore
force-pushed
the
symbols-as-weakmap-keys
branch
from
aff8342
to
4cd1eac
Compare
7 tasks
mhofman
suggested changes
May 16, 2022
Sounds good. Github is erroring whenever I try and commit the suggestions. "this diff has recently been updated"
I'll go old school and apply the suggestions manually |
Co-authored-by: Mathieu Hofman <86499+mhofman@users.noreply.github.com>
|
@leobalter has mentioned that it would be useful to get links to rendered previews of the spec. I agree. I'm going to close this PR and re-open one but this time targeting the main upstream 262 repo. It looks like PRs there get previews generated automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to tc39#2777
Stage 2 specification text for Symbols as WeakMap keys for review.
The proposed spec has been written as a PR against the full spec due to the high number of small tweaks to non-normative descriptions to sections such as liveness.
A more minimal proposal specification with only the core API changes is available at http://tc39.es/proposal-symbols-as-weakmap-keys