Implement REPLACE #1085
Merged
Implement REPLACE #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly b.c. of the unique_ptr), but we will see.
joka921
commented
Sep 6, 2023
Comment on lines
173
to
176
| struct RegexValueGetter { | ||
| std::unique_ptr<re2::RE2> operator()(SingleExpressionResult auto&& input, | ||
| const EvaluationContext* context) const | ||
| requires requires { StringValueGetter{}(AD_FWD(input), context); } { |
There was a problem hiding this comment.
TODO Comment the regexValueGetter and maybe move it somewhere.
also TODO Can we implement the Ordinary regex expression as an NARY-Operation with specialized functions?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
+ Coverage 79.89% 80.22% +0.33%
==========================================
Files 277 279 +2
Lines 26426 26792 +366
Branches 3266 3301 +35
==========================================
+ Hits 21113 21495 +382
+ Misses 3961 3937 -24
- Partials 1352 1360 +8
☔ View full report in Codecov by Sentry. |
hannahbast
requested changes
Sep 6, 2023
hannahbast
approved these changes
Sep 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
REPLACEfunction is now implemented. Note the following details:According to the standard,
REPLACEtakes an optional fourth argument for the flags. This is not yet supported. However, the flags can equivalently be prepended to the regular expression. For example, to get a case-insensitive regular expression, prepend(?i). The newRegexValueGetteris not yet used inFILTERclauses, where prefix regular expressions are treated specially for efficiency reasons.For constant values that are repeated multiple times (for each result row), the value is now evaluated only once and then repeated. In particular, in a
REPLACEwith a constant regular expression (the typical case), the regular expression is now compiled only once. This also avoids copying a constant string (for example, in a call toCONCAT) many times.