Skip to content

Commit

Permalink
update url_pattern to pass more wpt on node.js
Browse files Browse the repository at this point in the history
  • Loading branch information
anonrig committed Jan 24, 2025
1 parent ecdb978 commit e24821a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
2 changes: 0 additions & 2 deletions include/ada/implementation.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ bool can_parse(std::string_view input,
* @param input valid UTF-8 string or URLPatternInit struct
* @param base_url an optional valid UTF-8 string
* @param options an optional url_pattern_options struct
* @param provider an optional regex provider. if not provided, it will
* use ada::url_pattern_regex::std_regex_provider
* @return url_pattern instance
*/
template <url_pattern_regex::regex_concept regex_provider =
Expand Down
5 changes: 0 additions & 5 deletions include/ada/url_pattern-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ url_pattern_component<regex_provider>::create_component_match_result(
auto result =
url_pattern_component_result{.input = std::string(input), .groups = {}};

// If input is empty, then groups will always be empty.
if (input.empty() || exec_result.empty()) {
return result;
}

// Optimization: Let's reserve the size.
result.groups.reserve(exec_result.size() - 1);

Expand Down

0 comments on commit e24821a

Please sign in to comment.