Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ada::idna to c++20 #733

Merged
merged 1 commit into from
Sep 6, 2024
Merged

update ada::idna to c++20 #733

merged 1 commit into from
Sep 6, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 6, 2024

Updates idna code to main branch of the project

lemire
lemire approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice how our CI turns green.

So satisfying.

@anonrig anonrig merged commit b431670 into main Sep 6, 2024
28 checks passed
@anonrig anonrig deleted the update-idna-to-c20 branch September 6, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonrig @lemire