Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cannot be merged because we have no testing for UTF-16.
The proposed strategy here is to convert everything in UTF-8. Note that our entire codebase so far is UTF-8 specific: it makes no sense to accept anything but UTF-8 unless we do a fair amount of reengineering.
It is common these days to have the core engine run in UTF-8 and to view UTF-16 as something you convert from or to.