Call spi_write_blocking directly for RP2040 #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is around a 6-13x speed up in graphicstest (at 62.5Mhz)
PaintYourDragon
suggested changes
Sep 14, 2021
There was a problem hiding this comment.
Impressive! Would be happy to approve as-is…but…as long as you’re in there, would you consider adding same to writePixels() as well? Would improve BMP drawing, things like that.
(As in…if you’re busy, no worries…I can merge as-is and then bungle my way through adding it there, if necessary.)
Switch SPI to 16-bit for little-endian, write bytes as-is for big-endian
|
Haven't tried BMP drawing, but with the original change a 320x240 8x faster was pretty good, but taking advantage of hardware 16-bit writes and doing one write gets it down to around 27388us/38x faster! Hmm, 16-bit writes might also help for fills... think I've done enough for now though 😄 |
PaintYourDragon
approved these changes
Sep 15, 2021
Appease clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips some layers and improves performance a lot. Likely overlaps with #343 a bit.
graphicstestimprovements (62.5MHz):