-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functions for controlling additional comparator settings #99
Conversation
Added classes and setter/getter functions for comparator mode, latch, and polarity settings. Also added a read_config function to read the configuration register of the ads1x15 chip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about read_config()
. Looks good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove read_config and write_config. It doesn't match the model of other drivers where the driver state is the device state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.4.0 from 2.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#99 from RoaCode/comparator_settings Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_RFM#2 from FoamyGuy/msgpack_example Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.23.1 from 1.23.0: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#85 from FoamyGuy/use_ruff Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Added classes and setter/getter functions for comparator mode, latch, and polarity settings. Also added a read_config function to read the configuration register of the ads1x15 chip.