Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Celsius spelling #36

Merged
merged 1 commit into from
Jun 21, 2022
Merged

fix Celsius spelling #36

merged 1 commit into from
Jun 21, 2022

Conversation

vladak
Copy link
Contributor

@vladak vladak commented Jun 21, 2022

This change fixes spelling of the Celsius.

This will break pre-existing code such as:

   sgp30_sensor.set_iaq_relative_humidity(
            celcius=temp_celsius, relative_humidity=relative_humidity
        )

however will be easier on the eyes :-)

dhalbert
dhalbert approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@dhalbert dhalbert merged commit b62a473 into adafruit:main Jun 21, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 22, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@a476ee6)
c921168 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 5.0.0 from 4.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#164 from dannystaple/use-connection-errors

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.5.0 from 4.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#101 from makermelissa/multidisplay-support

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 3.0.0 from 2.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#36 from vladak/celsius

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 1.10.5 from 1.10.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#14 from tekktrik/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 4.1.1 from 4.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Logging#32 from tekktrik/doc/fix-doc-and-types
benthorner added a commit to benthorner/snsary that referenced this pull request Jul 10, 2022
@benthorner
Fix SGP30 sensor to work with new library version
8cdeed8 
Works with [^1].

[^1]: adafruit/Adafruit_CircuitPython_SGP30#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladak @dhalbert