Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unprotected the
readRegister8
method inAdafruit_MMA8451.h
Leaving this function protected makes it impossible to implement some of the key features in the chip. These methods are detailed in NXPs application notes .
For example, in AN4070 on page 11: clearing interrupts register flags is completed by a direct register read, and safely bit setting the MMA8451 control registers is completed by first reading the current register state, setting the relevant bits, and then writing the updated state.
If I have time at the completion of my project I would gladly add the features we're building into the main library, but for the time being, protecting
readRegister8
makes many of the chips features unusable with this library's current state.