Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOX Index has a baseline of 1 for Sensirion (only known usage) #55

Closed
tyeth opened this issue Jan 6, 2025 · 0 comments · Fixed by #56
Closed

NOX Index has a baseline of 1 for Sensirion (only known usage) #55

tyeth opened this issue Jan 6, 2025 · 0 comments · Fixed by #56
Assignees
@tyeth

Comments

@tyeth
Copy link
Contributor

tyeth commented Jan 6, 2025

The code comment clearly states the NOX index is using a baseline value of 100, like the VOC Index, but the NOX index has a baseline value of 1 according to the Sensirion documentation

Adafruit_Sensor/Adafruit_Sensor.h

Line 154 in 7b2473b

float nox_index; /**< NOx (Nitrogen Oxides) index where 100 is normal

Docs:
SGP40 gas index algorithm repo + docs mentioning baselines of VOC 100 and NOX 1:
https://github.com/Sensirion/gas-index-algorithm/blob/b70ae926519fe66d5f8f8620f3250d1a376b8b22/python-wrapper/sensirion_gas_index_algorithm/gas_index_algorithm.py#L58C99-L58C108

NOX Index Specific documentation:
https://sensirion.com/media/documents/9F289B95/6294DFFC/Info_Note_NOx_Index.pdf
@tyeth tyeth self-assigned this Jan 6, 2025
tyeth added a commit to tyeth/Adafruit_Sensor that referenced this issue Jan 6, 2025
@tyeth
Fix NOX index baseline value in comment
b0632cd 
Fixes adafruit#55

Testing CoPilot Workspaces to solve this complicated one line issue ;)

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/adafruit/Adafruit_Sensor/issues/55?shareId=XXXX-XXXX-XXXX-XXXX).
@tyeth tyeth mentioned this issue Jan 6, 2025
Merged
@tyeth tyeth closed this as completed in #56 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyeth tyeth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NOX index baseline value in comment tyeth/Adafruit_Sensor
1 participant
@tyeth