Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix USB-MSC not re-attaching #667

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Fix USB-MSC not re-attaching #667

merged 2 commits into from
Dec 10, 2024

Conversation

brentru
Copy link
Member

@brentru brentru commented Dec 9, 2024

This pull request resolves the following bug: After writing a default secrets.json file to the filesystem, the board must be manually reset.

This pull request re-initializes USB-MSC after writing to secrets.json. It also adds improvements for code clarity to the createSecretsFile() function.

@brentru brentru requested a review from tyeth December 9, 2024 16:58
Copy link
Contributor

@tyeth tyeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad, I forgot that locally I've changed that tinyusb reattach to come just after the writeToBootOut instruction

src/provisioning/tinyusb/Wippersnapper_FS.cpp Outdated Show resolved Hide resolved
@brentru brentru merged commit 16bc28a into main Dec 10, 2024
39 checks passed
@brentru brentru deleted the patch-usb-msc-bug branch December 10, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants